Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTG Test Update - RT 6.1 - LLDP neighbor verification change #1887

Open
wants to merge 107 commits into
base: main
Choose a base branch
from
Open

OTG Test Update - RT 6.1 - LLDP neighbor verification change #1887

wants to merge 107 commits into from
+22 −21

Conversation

octpetre
Copy link
Contributor

@octpetre octpetre commented Jul 14, 2023 •
edited
Loading

This changes is required in order to correctly match the status of an LLDP neighbor based on it oc telemetry not configuration.
Resolves #587

@octpetre octpetre requested review from a team as code owners July 14, 2023 19:51
@octpetre octpetre requested review from a team and jasdeep-hundal July 14, 2023 19:51
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 14, 2023 •
edited
Loading

Pull Request Functional Test Report for #1887 / 4a79fba

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-6.1: Core LLDP TLV Population
Cisco 8000E status
 RT-6.1: Core LLDP TLV Population
Cisco XRd status
 RT-6.1: Core LLDP TLV Population
Juniper ncPTX status
 RT-6.1: Core LLDP TLV Population
Nokia SR Linux status
 RT-6.1: Core LLDP TLV Population
Openconfig Lemming status
 RT-6.1: Core LLDP TLV Population

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-6.1: Core LLDP TLV Population
Cisco 8808 status
 RT-6.1: Core LLDP TLV Population
Juniper PTX10008 status
 RT-6.1: Core LLDP TLV Population
Nokia 7250 IXR-10e status
 RT-6.1: Core LLDP TLV Population

Help

@coveralls
Copy link

coveralls commented Jul 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 12356678562

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 12343488153: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

jasdeep-hundal
jasdeep-hundal requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jasdeep-hundal jasdeep-hundal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README suggests we need to change the structure of the test overall.

Reading it closely, it seems to imply that we need to specifically test with LLDP enabled before disabling it, and that we do not disable LLDP at the interface level for the 2nd test.

I am happy with that in a follow-up patch though, let's leave the re-opened bug open in that case though.

feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go Show resolved Hide resolved
@octpetre octpetre requested a review from jasdeep-hundal July 25, 2023 21:23
octpetre added 20 commits March 8, 2024 14:36
@octpetre
Merge branch 'main' into lldp_verification_changes
e78e623
@octpetre
Merge branch 'main' into lldp_verification_changes
62e4081
@octpetre
Merge branch 'main' into lldp_verification_changes
2d525e6
@octpetre
Merge branch 'main' into lldp_verification_changes
b2652e6
@octpetre
Merge branch 'main' into lldp_verification_changes
57ce98c
@octpetre
Merge branch 'main' into lldp_verification_changes
15f3f8b
@octpetre
Merge branch 'main' into lldp_verification_changes
60abd8e
@octpetre
Merge branch 'main' into lldp_verification_changes
01c8e5a
@octpetre
Merge branch 'main' into lldp_verification_changes
350e95f
@octpetre
Merge branch 'main' into lldp_verification_changes
48ee2f8
@octpetre
Merge branch 'main' into lldp_verification_changes
5d0c888
@octpetre
Merge branch 'main' into lldp_verification_changes
f9a6b99
@octpetre
Merge branch 'main' into lldp_verification_changes
6604d86
@octpetre
Merge branch 'main' into lldp_verification_changes
37e29ab
@octpetre
Merge branch 'main' into lldp_verification_changes
6a84d59
@octpetre
Merge branch 'main' into lldp_verification_changes
86bb195
@octpetre
Merge branch 'main' into lldp_verification_changes
7142e71
@octpetre
Merge branch 'main' into lldp_verification_changes
8dbbb47
@octpetre
Merge branch 'main' into lldp_verification_changes
c9a7121
@octpetre
Merge branch 'main' into lldp_verification_changes
bde4ffe
@self-maurya self-maurya requested a review from alokmtri-g October 8, 2024 06:59
@alokmtri-g
Copy link

alokmtri-g commented Dec 26, 2024 •
edited
Loading

TestLLDPEnabled is failing in neighbor state verification:

PR1887.log

third_party/openconfig/featureprofiles/feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go:288: Telemetry for Node port neighbor at /lldp/interfaces/interface[name=et-0/0/1]/neighbors/neighbor[id=02:00:22:01:01:01-00:00:00:00:00:01]:

     {
       "openconfig-lldp:id": "02:00:22:01:01:01-00:00:00:00:00:01",
       "openconfig-lldp:state": {
         "age": "24",
         "chassis-id": "02:00:22:01:01:01",
         "chassis-id-type": "MAC_ADDRESS",
         "id": "02:00:22:01:01:01-00:00:00:00:00:01",
         "last-update": "24",
         "management-address": "",
         "management-address-type": "",
         "port-description": "",
         "port-id": "00:00:00:00:00:01",
         "port-id-type": "MAC_ADDRESS",
         "system-description": "Lldp emulation on Ixia-IxHw",
         "system-name": "ixia-otg",
         "ttl": 120
       }
     }
 **third_party/openconfig/featureprofiles/feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go:298: /state/port-id: got &00:00:00:00:00:01, want &6/3
 third_party/openconfig/featureprofiles/feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go:298: /state/port-id-type: got MAC_ADDRESS, want INTERFACE_NAME**

@rohit-rp
Copy link
Contributor

Update please?

@arkajyoti-cloud arkajyoti-cloud requested a review from a team as a code owner January 20, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdeep-hundal jasdeep-hundal Awaiting requested review from jasdeep-hundal

@alokmtri-g alokmtri-g Awaiting requested review from alokmtri-g

Requested changes must be addressed to merge this pull request.

Assignees

@octpetre octpetre

Labels
keysight-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTG: RT-6.1: Core LLDP TLV Population
7 participants
@octpetre @OpenConfigBot @coveralls @alokmtri-g @rohit-rp @jasdeep-hundal @arkajyoti-cloud